Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a hash of the current index.html for future-proofing #1

Open
eeeeeta opened this issue Jul 8, 2018 · 0 comments
Open

Store a hash of the current index.html for future-proofing #1

eeeeeta opened this issue Jul 8, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@eeeeeta
Copy link
Collaborator

eeeeeta commented Jul 8, 2018

16:31 <lkosov> Also, looking at the code in main.rs, might it be a good idea to future-proof it by either comparing index.html against a local copy of the default, or a hash of the current default? As it is, if the index.html in /etc/skel/public_html ever changes for some reason, it'll throw the script off for pre-existing accounts.

An ideal implementation would assume that there will be different versions of the index.html file and plan for this, by declaring a static array of version numbers and SHA hashes, and potentially exposing this in the resultant users.json output.

@eeeeeta eeeeeta self-assigned this Jul 8, 2018
@eeeeeta eeeeeta added the enhancement New feature or request label Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant