Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate email uniqueness #31

Open
vilmibm opened this issue Feb 24, 2018 · 4 comments
Open

validate email uniqueness #31

vilmibm opened this issue Feb 24, 2018 · 4 comments

Comments

@vilmibm
Copy link
Member

vilmibm commented Feb 24, 2018

currently people can sign up for an account with an email we already have on file. this is a bug and is currently caught manually. fail form validation for non-unique emails.

@MineRobber9000
Copy link
Member

Where are emails stored? I could probably bang this out in a PR.

@vilmibm
Copy link
Member Author

vilmibm commented Feb 27, 2018

@MineRobber9000 They are stored in the Postgresql database via Django. The fix for this issue should be adding a unique=True to the email field in the Townie model and then creating migrations for the change.

@MineRobber9000
Copy link
Member

MineRobber9000 commented Jun 2, 2018

What should I do with the migration? I know I should django-admin makemigrations (or however that tool is meant to be run) but what do I do with the resulting migration?

@vilmibm
Copy link
Member Author

vilmibm commented Jun 5, 2018

makemigrations should result in some new files. you should commit them and then you'll be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants