Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: reduces the probability of deleting normal peers when the store becomes unavailable #7249

Closed
lhy1024 opened this issue Oct 25, 2023 · 1 comment · Fixed by #7240, #7294 or #7315
Closed

checker: reduces the probability of deleting normal peers when the store becomes unavailable #7249

lhy1024 opened this issue Oct 25, 2023 · 1 comment · Fixed by #7240, #7294 or #7315
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug. type/development The issue belongs to a development tasks

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 25, 2023 •
edited
Loading

Development Task

we should replace the disconnect store's peer with the orphan peer.
ref tikv/tikv#15799
@lhy1024 lhy1024 added the type/development The issue belongs to a development tasks label Oct 25, 2023
@lhy1024 lhy1024 mentioned this issue Oct 25, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Oct 26, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (#7240)
f9b476d 
close #7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Oct 30, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (tikv#7240)
c7e2c27 
close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 mentioned this issue Oct 30, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Oct 30, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (#7240) (#7286)
6101f18 
close #7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024 lhy1024 mentioned this issue Nov 2, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 3, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
689fcbe 
…peer (#7294)

close #7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 3, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
a9633ae 
…peer (tikv#7294)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
This was referenced Nov 3, 2023
Merged
Merged
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 6, 2023 •
edited
Loading

This full modify about this issue is https://github.com/lhy1024/pd/compare/4ba0fa6..bcb22ae

ti-chi-bot bot pushed a commit that referenced this issue Nov 6, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
c332ddc 
… peers (#7315)

close #7249

Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 6, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
04cb434 
… peers (tikv#7315)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Nov 6, 2023
@lhy1024
checker: replace down check with disconnect check when fixing orphan …
65de8fc 
…peer(#7294) (#7295)

close #7249

Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (tikv#7240)
ae93757 
close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
61ed8c5 
…peer (tikv#7294)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
6e4981f 
… peers (tikv#7315)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 mentioned this issue Nov 8, 2023
Merged
@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Nov 8, 2023
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (tikv#7240)
51aa7fb 
close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
d162921 
…peer (tikv#7294)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
ddee72c 
… peers (tikv#7315)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (tikv#7240)
5f65151 
close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
2c55db5 
…peer (tikv#7294)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
6a590d0 
… peers (tikv#7315)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 mentioned this issue Nov 8, 2023
Merged
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: add disconnected check when fix orphan peers (tikv#7240)
b1796a4 
close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: replace down check with disconnect check when fixing orphan …
88d53c1 
…peer (tikv#7294)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this issue Nov 8, 2023
@lhy1024
checker: avoid unnecessary remove disconnected peer with multi orphan…
545c23d 
… peers (tikv#7315)

close tikv#7249

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 mentioned this issue Nov 8, 2023
Merged
@ti-chi-bot ti-chi-bot added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Nov 8, 2023
ti-chi-bot bot added a commit that referenced this issue Nov 8, 2023
@lhy1024 @ti-chi-bot
checker: reduces the probability of deleting normal peers when the st…
a22710c 
…ore becomes unavailable (#7249) (#7330)

close #7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024 lhy1024 mentioned this issue Nov 9, 2023
Merged
@niubell niubell mentioned this issue Nov 15, 2023
Merged
18 tasks
ti-chi-bot bot added a commit that referenced this issue Nov 22, 2023
@lhy1024 @ti-chi-bot
checker: reduces the probability of deleting normal peers when the st…
5a95241 
…ore becomes unavailable (#7249) (#7337)

close #7249

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@niubell niubell mentioned this issue Nov 30, 2023
Merged
16 tasks
@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Dec 5, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@lhy1024
checker: reduces the probability of deleting normal peers when the st…
b54ac93 
…ore becomes unavailable (#7249) (#7334)

close #7249

Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 23, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7240
3d9d326 
close tikv#7249

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 23, 2024
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 23, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7240
6ef8570 
close tikv#7249

Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 30, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7240
4f9d241 
close tikv#7249

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 30, 2024
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 30, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7240
5799824 
close tikv#7249

Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 2, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7240
0d29602 
close tikv#7249

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug. type/development The issue belongs to a development tasks
Projects
Questions and Bug Reports
Status: Need Triage
Milestone
No milestone
2 participants
@lhy1024 @ti-chi-bot