Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local chat history deletion #240

Open
leyloe opened this issue Feb 13, 2024 · 9 comments
Open

add local chat history deletion #240

leyloe opened this issue Feb 13, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@leyloe
Copy link

leyloe commented Feb 13, 2024

and allow them to expire from the device

@leyloe leyloe added the enhancement New feature or request label Feb 13, 2024
@hantu85
Copy link
Contributor

hantu85 commented Feb 13, 2024

Currently, there is no way to delete local history of a single chat due to the way how messages are stored and synced from the server (removal of lastest message can result in resynchronizion of them on reconnection).

Thank you for reporting this feature request. We will think about adding this feature in one of the future releases.

@licaon-kter
Copy link

Can't you just replace their contents in the local DB?

@hantu85
Copy link
Contributor

hantu85 commented Feb 13, 2024

That is not the same and I do not suppose this would be expected result of chat history removal operation. Anyway, that would require some work and it would need to be part of the future releases as I've stated.

@licaon-kter
Copy link

That is not the same and I do not suppose this would be expected result of chat history removal operation.

Not sure a follow, in a federated system we should not expect the history to disappear from MAM or other devices.

While that is true, I see no issue with replacing current local DB entries with "NIL" and keep the rest as it is, so there's no reason to pull from MAM and re-get the same messages because the DB will always say "I'm up to date"

But the user get what they want, if they open a chat it is empty since you can skip rendering any messages which are "NIL" (or whatever pattern you choose)

it would need to be part of the future releases as I've stated.

as always :)

@hantu85
Copy link
Contributor

hantu85 commented Feb 13, 2024

That is not the same and I do not suppose this would be expected result of chat history removal operation.

Not sure a follow, in a federated system we should not expect the history to disappear from MAM or other devices.

What I mean, is removal is removal, so all details about the message exchange should be removed from the device if that is possible. Not only tombstoned or have body replaced, but actually removed with all metadata about the message being removed as well, ie. who sent message, when, etc.

In other case, the name of this functionality should be "hide" instead of "delete" and I would prefer not to mislead users.

@licaon-kter
Copy link

Note that given the spread of a message (MAM, other devices, contacts) you'll always be "hiding" more or less.

Now, @fu3x11 what is your usecase (given the discussion above), local hide or?

@hantu85
Copy link
Contributor

hantu85 commented Feb 13, 2024

Question was about removal of data from the local device storage, not from the server.

@leyloe
Copy link
Author

leyloe commented Feb 13, 2024

Note that given the spread of a message (MAM, other devices, contacts) you'll always be "hiding" more or less.

Now, @fu3x11 what is your usecase (given the discussion above), local hide or?

yes local hiding, on gajim, i have a setup where all messages expire after one week, server archival off, and i manually delete all chat history on that client when necessary, or for individual chats. (all locally obviously)

another cool feature gajim has, to prevent unauthorized group chat or dm leaks, is not trusting your contacts new omemo fingerprints by default, (it will be switched off completely), until you and your contact has consulted and verified that the new device was indeed him with one of many methods, then said fingerprint may be manually trusted by you

@leyloe
Copy link
Author

leyloe commented Jul 17, 2024

Question was about removal of data from the local device storage, not from the server.

messages can be archived on the server? let's just say your device gets seized by very bad people, so they have your keys, but there's no messages on the device. but the xmpp server stored your encrypted messages without your permission (with server side archival off on your account), and said server gave the bad guys the encrypted messages, would they be able to decrypt them? is there any mechanism in place to prevent that? does signal have a counter for that kind of attack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants