Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No audio/video buttons on iOS 16.7. #230

Open
germanicianus opened this issue Sep 27, 2023 · 6 comments
Open

No audio/video buttons on iOS 16.7. #230

germanicianus opened this issue Sep 27, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@germanicianus
Copy link

germanicianus commented Sep 27, 2023

Describe the bug
See issue subject.

To Reproduce
Steps to reproduce the behavior:

  1. Have Siskin IM installed on an iPhone with iOS 16.7.
  2. Open the chat of a contact.
  3. Audio and video buttons are not shown.
  4. Open iOS Settings and go to Siskin IM.
  5. Access settings for Microphone, Camera and Local Network are missing.

Expected behavior
Audio and video call buttons are shown.

Screenshots
Can be attached later in case needed.

Details

  • Siskin Version: 7.3.3
  • iOS version: 16.7
  • iPhone model: 13

Additional context

  • Working audio/video calling between iPhone 7 Plus with iOS 15.7.9 and Android blabber.im.
@germanicianus germanicianus added the bug Something isn't working label Sep 27, 2023
@licaon-kter
Copy link

Your contact uses which Client?

@germanicianus
Copy link
Author

germanicianus commented Sep 28, 2023

@licaon-kter, please see below.

Works:
iPhone 7 Plus iOS 15.7.9 <> Android blabber.im

Doesn't work (no buttons):
iPhone 13 iOS 16.7 <> Android blabber.im
iPhone 13 iOS 16.7 <> iPhone 7 Plus iOS 15.7.9

So I think it's some issue related to the rights code/management on iOS 16.7. Possibly Apple changed something with the major iOS upgrade from 15 to 16.

@licaon-kter
Copy link

The iOS clients are in foreground both when you try yes?

You both added yourselves as contacts, yes?

@hantu85
Copy link
Contributor

hantu85 commented Sep 28, 2023

@germanicianus I think you might encounter a slightly more complicated issue.

For the buttons to not show up (for 1-1 chats), most likely reason could be your device locale. According to the guidelines from Apple (legal stuff), CallKit (framework used for VoIP integration on iPhone) cannot be used for applications sold using AppStore in China.

As Apple did not provide any way to detect that (and disable usage of CallKit only in this case), the only solution that we had was to disable usage of CallKit when device locale region code is set to CN or CHN.

And disabling CallKit will result in buttons not being available, as feature will not work in this case. Also, disable CallKit will not use microphone nor camera, so it will not ask for permissions to use them nor register for that - Siskin does that only when user actually wants to use functionality requiring mic or camera.

@germanicianus
Copy link
Author

germanicianus commented Sep 28, 2023

@hantu85, you hit the nail on the head. On the iPhone 13, Siskin IM has been installed from the China AppStore.

If not already there, a prominent hint should be put onto the Siskin IM China AppStore page - something like you stated.

According to the guidelines from Apple (legal stuff), CallKit (framework used for VoIP integration on iPhone) cannot be used for applications sold using AppStore in China.

Did Apple give any useful reasoning? FaceTime also works on the iPhones sold in China, so more information on that would be really helpful.

I suggest to use this issue as reference for putting up some documentation into appropriate places.

@germanicianus
Copy link
Author

Just as reference for people reading this issue - commit ab733cb added the change of disabling CallKit in Siskin IM for users having their region set to China.

The notice Apple sends out to developers having enabled CallKit for China contains below paragraph.

Recently, the Chinese Ministry of Industry and Information Technology (MIIT) requested
that CallKit functionality be deactivated in all apps available on the China App Store.
During our review, we found that your app currently includes CallKit functionality and
has China listed as an available territory in App Store Connect.

Source: https://support.dolby.io/hc/en-au/articles/1500007496422-iOS-App-approval-CallKit-in-China-region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants