Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new docs and bugfixes from juliacon #11

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

tiemvanderdeure
Copy link
Owner

No description provided.

@tiemvanderdeure tiemvanderdeure changed the title additions since juliacon new docs and bugfixes from juliacon Sep 27, 2024
@rafaqz
Copy link
Collaborator

rafaqz commented Sep 27, 2024

Also see some of the recent changes to DimensionalData.jl vitepress by @lazarusA

Fixes to add doc version dropdown, links that aren't broken etc
rafaqz/DimensionalData.jl#804
rafaqz/DimensionalData.jl#744
rafaqz/DimensionalData.jl#746

@tiemvanderdeure
Copy link
Owner Author

Yea still trying to figure it out. I looked at the Rasters docs also but maybe DD is the better example. Also I can't get the docs to build locally on my laptop, but I don't know if that's because something is off in this repo or on my setup (I'm on windows which isn't ideal)

@lazarusA
Copy link

DD should build locally. I did all my tests that way. If not, please report back.

@lazarusA
Copy link

@tiemvanderdeure
Copy link
Owner Author

Thanks for chipping in @lazarusA!

From the preview generated by the check it seems it at least kind of worked:
https://tiemvanderdeure.github.io/SpeciesDistributionModels.jl/previews/PR11/

Also, this migth help for doing local builds.

https://juliadatacubes.github.io/YAXArrays.jl/stable/development/contribute.html#Build-docs-locally

I did this, but get a Warning: Documenter could not auto-detect the building environment. Skipping deployment. and the locally generated page shows a (vitepress-themed) 404 error.

@rafaqz
Copy link
Collaborator

rafaqz commented Sep 27, 2024

@tiemvanderdeure yes DD is the better example, I still need to add some of those changes to Rasters

@tiemvanderdeure
Copy link
Owner Author

@rafaqz or @lazarusA could you help me understand what went wrong here? The documentation doesn't really give any error so that doesn't say much - I also just added some text to a .md file so I can't see what I possibly could have broken?

I tried to build locally and it gets stuck on ExpandTemplates: expanding markdown templates, which I can find lots of issues about but not any clear solution to.

@lazarusA
Copy link

I would guess that is the data download. Is it working?

@tiemvanderdeure
Copy link
Owner Author

Okay it wasn't quite that but it put me on the right path, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants