date_count_between translations #1496
Conversation
|
@hadley I noticed there was now a conflict with the news file so I have fixed that. Would it be possible to review this pr, hopefully it adds some nice functionality? (the matching functionality was also added in the duckdb 1.0 release duckdb/duckdb-r#166) |
|
I’m not working on dbplyr at the moment but I’ll definitely do it when I next am. (And I’ll take care of any merge conflicts so you don’t need to worry about that) |
|
No problem @hadley, thanks for letting me know. When you do get to dbplyr, please just tag me if anything needs to be done and I'd be more than happy to contribute (I'll also be coming to the tidyverse developer day, so happy to work on anything related then too!) |
|
@edward-burn thank you! And looking forward to seeing you at TDD! |
There was a problem hiding this comment.
Great! We'll be excited to get this merged in if you're game to revisit this PR for a few changes.
I've left one comment on how to revise an error message in this PR that should apply to each of the other new pieces of erroring code. Once the rest of those are resolved, this should be in a great spot!
Co-authored-by: Simon P. Couch <[email protected]>
Co-authored-by: Simon P. Couch <[email protected]>
|
thanks @simonpcouch! I have updated the pr based on the review, hopefully now all looks good |
There was a problem hiding this comment.
Thanks for making those changes, @edward-burn. Looking good!
For #1495, adds translations for clock::date_count_between() for a number of backends along with tests and update of news.