Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ApproveMan not selectable as reviewer #693

Open
EnergySRE opened this issue Jan 14, 2022 · 0 comments
Open

[BUG] ApproveMan not selectable as reviewer #693

EnergySRE opened this issue Jan 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@EnergySRE
Copy link

Describe the bug
We've got a private repo (github.com/CamusEnergy/bando), for which we're trying to set up ApproveMan. I'm doing testing on my private fork with the same configuration (github.com/EnergySRE/bando), and seeing the same behavior in both places.

To Reproduce
Steps to reproduce the behavior:

  1. Install ApproveMan with org-level permissions from GitHub Marketplace
  2. Set "Repository access" to "All repositories"
  3. Create a branch with the config below*
  4. ApproveMan appears in the automated checks on the PR (screen shot below)
  5. ApproveMan does not appear as an option on the reviewer list

I also tried adding ApproveMan as an authorized user to our organization, and receive a "no such user" error.

Expected behavior
I expect to be able to select ApproveMan as a reviewer and have it approve my PR based on the content of my config.

Screenshots

Automated checks pass:

Screen Shot 2022-01-14 at 11 34 48 AM

ApproveMan not selectable as reviewer:

Screen Shot 2022-01-14 at 11 40 25 AM

Additional context

Here's the config we're using:

ownership_rules:
  directory_matching_rules:
    - name: Markdown-only changes
      path: **/*.md
    - name: Doc folder
      path: doc/*
@EnergySRE EnergySRE added the bug Something isn't working label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant