Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the point of bootstrap_agent.sh #50

Open
smeyerhot opened this issue Aug 8, 2021 · 3 comments
Open

What is the point of bootstrap_agent.sh #50

smeyerhot opened this issue Aug 8, 2021 · 3 comments

Comments

@smeyerhot
Copy link

Description of the problem / feature request:

It looks like bootstrap_agent.sh does just about nothing. What is the point of this script, and why do you have it in a s3 bucket?

🐛 Bug Report: Expected Behavior

🐛 Bug Report: Actual Behavior

🐛 Bug Report: Steps to Reproduce the Problem

🐛 Bug Report: Specifications

  • Version:
  • Platform:
@thundergolfer
Copy link
Owner

If you look through the history of that file, you'll see it used to install some stuff that I hadn't baked into the AWS AMI, such as the Black Python source code formatter.

Recently I removed the need to install anything, and so the file became a kind of 'no op', but the Buildkite config still expects to find and run that file, so it still exists.

In future I could just remove the config that has Buildkite expecting to run that file, and then remove the file.

@smeyerhot
Copy link
Author

Ok, fair enough. Is the ami is for the buildkite agent?

@thundergolfer
Copy link
Owner

Yes the AMI is for the Buildkite agent. It's not a nice dev-loop to have to rebuild AMIs, but not bothered to change it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants