Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bootcamp Task] Fit-in not working as expected #3

Open
heynemann opened this issue Jan 29, 2022 · 0 comments
Open

[Bootcamp Task] Fit-in not working as expected #3

heynemann opened this issue Jan 29, 2022 · 0 comments
Labels
bug Bug that was reported by one of thumbor's users L1 Level 1 Bootcamp Task task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.

Comments

@heynemann
Copy link
Member

Areas of Expertise

Imaging and Debugging.

Summary

A user claims that fit-in is not returning the image they expect. We need to triage and ensure this is a problem. The issue is at thumbor/thumbor#1330

Involved Modules

Task Relevance

Ensuring we fix all issues contributes to thumbor reputations as being reliable and battle-tested.

Further Details

We need to create a thumbor.conf file that matches the user's situation, run thumbor and try to reproduce it.

How to complete this task?

Once you can reproduce the issue, you can close this task and create a new L2 task with whatever you found.

(no need to change this part in every task)

To complete this task, follow this workflow:

  1. Fork the involved repositories
  2. In each repository there's a documentation on how to install dependencies and initialize your environment
  3. Hack, in no particular order:
    • Write code & tests
    • Write new tests
    • Write docs
    • Improve design
    • Check that all tests pass
    • Repeat until you're satisfied
  4. Submit a pull request.
@heynemann heynemann added task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor. L1 Level 1 Bootcamp Task bug Bug that was reported by one of thumbor's users labels Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that was reported by one of thumbor's users L1 Level 1 Bootcamp Task task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.
Projects
None yet
Development

No branches or pull requests

1 participant