Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bootcamp Task] Upgrade thumbor-padding to Thumbor 7 #21

Open
heynemann opened this issue Jan 30, 2022 · 0 comments
Open

[Bootcamp Task] Upgrade thumbor-padding to Thumbor 7 #21

heynemann opened this issue Jan 30, 2022 · 0 comments
Labels
L2 Level 2 Bootcamp Task opensource Tasks that improve your opensource skills task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.

Comments

@heynemann
Copy link
Member

Areas of Expertise

open-source contributions

Summary

There's a cool project called thumbor-padding that needs to be upgraded to thumbor 7 (Thumbor 7 release notes - Look at the filters part!)

Involved Modules

List the modules the bootcamper has to interact with, like:

Task Relevance

Expands the list of projects with thumbor 7 compatibility as well as add a nice capability for users.

Further Details

  • First you should "asyncify" the filter in the repository
  • Then write tests to verify that the filter is indeed working
  • Then do a PR to the repository owner (@heynemann can approve)
  • Then we release a new version of thumbor-padding and 💰profit!

Proposed Solution

Just need to transform the filter into an async function as well as fix any issues in the codebase with python 3.

Remember to create a new virtualenv, install all the dependencies (usually can be done with pip install -e .[tests] but the setup.py for this project also needs to be updated. You can check thumbor's setup.py for that).

How to complete this task?

To complete this task, follow this workflow:

  1. Fork the involved repositories
  2. In each repository there's a documentation on how to install dependencies and initialize your environment
  3. Hack, in no particular order:
    • Write code & tests
    • Write new tests
    • Write docs
    • Improve design
    • Check that all tests pass
    • Repeat until you're satisfied
  4. Submit a pull request.
@heynemann heynemann added task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor. L2 Level 2 Bootcamp Task opensource Tasks that improve your opensource skills labels Jan 30, 2022
@heynemann heynemann assigned heynemann and unassigned heynemann Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Level 2 Bootcamp Task opensource Tasks that improve your opensource skills task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.
Projects
None yet
Development

No branches or pull requests

1 participant