Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bootcamp Task] Fit-in ZeroDivisionError #2

Open
heynemann opened this issue Jan 29, 2022 · 0 comments
Open

[Bootcamp Task] Fit-in ZeroDivisionError #2

heynemann opened this issue Jan 29, 2022 · 0 comments
Labels
bug Bug that was reported by one of thumbor's users L1 Level 1 Bootcamp Task task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.

Comments

@heynemann
Copy link
Member

Areas of Expertise

Debugging and Imaging

Summary

A user reported they got a bug when using the fit-in feature. We need to triage that bug and try to reproduce it. If we can't reproduce it with thumbor 7 latest version we can safely close the issue. The issue can be seen at thumbor/thumbor#1347.

Involved Modules

Task Relevance

It is key that we fix every single open bug to ensure thumbor keeps its battle tested reputation.

Further Details

Create a new thumbor.conf that matches what the user is reporting and run thumbor. Try to reproduce the issue. Reading the code in the stack the user reported usually helps.

How to complete this task?

This task will be completed once we identify whether there's a problem or not. If there's a problem, please create a new L2 task with what you found.

(no need to change this part in every task)

To complete this task, follow this workflow:

  1. Fork the involved repositories
  2. In each repository there's a documentation on how to install dependencies and initialize your environment
  3. Hack, in no particular order:
    • Write code & tests
    • Write new tests
    • Write docs
    • Improve design
    • Check that all tests pass
    • Repeat until you're satisfied
  4. Submit a pull request.
@heynemann heynemann added task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor. L1 Level 1 Bootcamp Task triage Task that's still pending triage. Please do not pick it up if you're a bootcamper. labels Jan 29, 2022
@heynemann heynemann self-assigned this Jan 29, 2022
@heynemann heynemann removed the triage Task that's still pending triage. Please do not pick it up if you're a bootcamper. label Jan 29, 2022
@heynemann heynemann removed their assignment Jan 29, 2022
@heynemann heynemann changed the title [Bootcamp Task] <title> [Bootcamp Task] Fit-in ZeroDivisionError Jan 29, 2022
@heynemann heynemann added the bug Bug that was reported by one of thumbor's users label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that was reported by one of thumbor's users L1 Level 1 Bootcamp Task task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.
Projects
None yet
Development

No branches or pull requests

1 participant