-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent format for message IDs #37
Comments
Supplement: I believe the reason why I did this was that it's harder to read byte representations in the CLI, so maybe the CLI should still print hex-encoded IDs. |
(Let's make sure to remove the deprecated |
I'd go with the type returned by the API. If the API returns hex values, we could keep them in hex, it's a bit easier to handle. But converting everyting to |
Well, the API just can't return bytes because HTTP. 😉 Another reason why |
Ok, go for |
DeliveryReceipt.message_ids
contains a list of IDs in bytes whereas the various send methods of theConnection
instance usually return a hex-encoded ID. This makes it really annoying to handle.We should unify the format. My personal tendency is to use bytes. This would definitely require a major version increase because it breaks API. Any thoughts, @dbrgn?
The text was updated successfully, but these errors were encountered: