Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thcrap] Only display not being able to digitally sign once. #243

Open
lilyremigia opened this issue Oct 14, 2023 · 1 comment
Open

[thcrap] Only display not being able to digitally sign once. #243

lilyremigia opened this issue Oct 14, 2023 · 1 comment

Comments

@lilyremigia
Copy link
Contributor

11>d:\repos\thcrap\thcrap\thcrap\src\runconfig.cpp(361): warning C4834: discarding return value of function with 'nodiscard' attribute

Also, I feel like the warning about digital signing doesn't have to happen every project...

16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : D:\Repos\thcrap\thcrap\cert.pfx not found. Binaries won't be digitally signed, and thcrap won't be able to automatically update itself.
16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : Please see README.md for instructions on how to generate this file.
@brliron
Copy link
Member

brliron commented Dec 5, 2023

The warning have been fixed. The release script warns me on warnings and errors, so we usually don't keep them for too long.

As for the thing about digital signing, I'll admit that I don't have this problem because I have a certificate in my build directory (I think that's a test certificate, but it may be the prod one). I think we could improve things on that side. The test certificate could be added to the git repository, which could help with automated testing, and we could try to find a way to have the warning only while building for release, and to have a warning if the certificate supplied doesn't match the sha256 of my prod certificate.

@lilyremigia lilyremigia changed the title [thcrap] Fix or silence compiler warning [thcrap] Only display not being able to digitally sign once. Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants