Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find games automatically" should search "C:\Program Files (x86)\上海アリス幻樂団" #234

Open
lilyremigia opened this issue Sep 6, 2023 · 6 comments

Comments

@lilyremigia
Copy link
Contributor

"Find games automatically" should search C:\Program Files (x86)\上海アリス幻樂団

ZUN's installer places the games here, by default.
Touhou 19's DLsite version, for example.
image

@brliron
Copy link
Member

brliron commented Sep 11, 2023

We look in the registry key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall for subkeys whose name starts with either 東方, or 弾幕アマノジャク (special case for th14.3). What does the registry uninstall key for th19 look like?

@lilyremigia
Copy link
Contributor Author

image

@lilyremigia
Copy link
Contributor Author

th19.reg.txt

@lilyremigia
Copy link
Contributor Author

@brliron
Because regularly installed games aren't Steam games, they get filtered out here.
https://github.com/thpatch/thcrap/blob/beb32924fc0034c46c848f1bcc8788f1f4d4e561/thcrap/src/search.cpp#L366C46-L366C46

@lilyremigia
Copy link
Contributor Author

lilyremigia commented Sep 17, 2023

But also, it's only in WOW6432Node. At least on Win11.

@brliron
Copy link
Member

brliron commented Oct 10, 2023

I completely forgot that I didn't implement official installers detection in #111 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants