Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu links '.active' #27

Open
qwertykeith opened this issue Aug 26, 2012 · 0 comments
Open

menu links '.active' #27

qwertykeith opened this issue Aug 26, 2012 · 0 comments

Comments

@qwertykeith
Copy link

really enjoying trawling through your code... i'm giving myself a crash course in backbone/require etc and this is really helping, so thanks heaps for that...

just one small thing.. maybe it's just be not implemented because of time constraints... but when you use backbone's history and press forward and back, shouldn't the menu item 'active' class follow along? that bit just doesn't seem very mvc-ish to me ... i think that small feature would be a really good way to demo how you can decouple that sort of functionality from the ui.. i had a go at fixing it for you, but i'm still haven't got my head completely around the code so i thought best to leave it :)

thanks again! k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant