Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-react-query-tailwind]: Fix Milestone for Issues and pull requests tab for single repo #1948

Open
hdJerry opened this issue Aug 21, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@hdJerry
Copy link
Contributor

hdJerry commented Aug 21, 2023

Currently milestones filter doesn't work by targeting the ID of the milestone.

Apparently, we can't filter by milestones for pull requests with the Graphql API so, you will need to extend the API by using the REST API version for that situation

Fix

  • replace milestone with milestoneNumber in the query
  • replace the id of the milestone with the number of the milestone
@hdJerry hdJerry added the good first issue Good for newcomers label Aug 21, 2023
@hdJerry hdJerry added this to the Q3 2023 Deliverables milestone Aug 21, 2023
@hdJerry hdJerry changed the title [next-react-query-tailwind]: Fix Milestone for Issues and pull request tab for single repo [next-react-query-tailwind]: Fix Milestone for Issues tab for single repo Aug 21, 2023
@hdJerry hdJerry changed the title [next-react-query-tailwind]: Fix Milestone for Issues tab for single repo [next-react-query-tailwind]: Fix Milestone for Issues and pull requests tab for single repo Aug 22, 2023
@hdJerry hdJerry self-assigned this Aug 28, 2023
@hdJerry
Copy link
Contributor Author

hdJerry commented Aug 30, 2023

I added some functions for the app rest API
restAPI.ts has the fetch API and the APIs needed to label, milestones and get the pull requests.

I also added the pull request parser named parseRESTAPIPullRequest to format the data to the format used to display the PR's

You can look at the Qwik and SolidStart showcase as a guide.

Please ensure you pull the latest from the main branch to see the changes in the Qwik or SolidStart

@Megio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants