Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable stale items #91

Open
danialgood opened this issue Mar 18, 2020 · 1 comment
Open

More reliable stale items #91

danialgood opened this issue Mar 18, 2020 · 1 comment

Comments

@danialgood
Copy link

It seems currently stale values are resurrected via shd get_stale which is not to be relied on.
This could be costly in cases which cache is expired and an answer is needed nevertheless.

Maybe a backup lrucache could be implemented alongside current structure that has a copy of recently accessed keys.

@thibaultcha thibaultcha changed the title more reliable stale items [enhancement] more reliable stale items Jun 19, 2020
@thibaultcha
Copy link
Owner

thibaultcha commented Feb 1, 2021

Hi,

Our usage of get_stale should be appropriate given we handle its edge-cases.

This could be costly in cases which cache is expired and an answer is needed nevertheless.

I think this relates to #94, aka serving stale items while re-validating.

I'd be inclined to close this issue as a duplicate of #94, unless you see a different issue with get_stale itself.

@thibaultcha thibaultcha changed the title [enhancement] more reliable stale items More reliable stale items Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants