Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Combined rounds should be more strict about missing times #86

Open
jfly opened this issue Mar 1, 2014 · 0 comments
Open

Combined rounds should be more strict about missing times #86

jfly opened this issue Mar 1, 2014 · 0 comments

Comments

@jfly
Copy link
Contributor

jfly commented Mar 1, 2014

I noticed that combined rounds don't check which solves were entered, all they require is that the very first time be entered. Here's the relevant code from WorkbookValidator:

Long result;
if (round.isCombined() && resultIdx > 1) {
    result = CellParser.parseOptionalSingleTime(resultCell, resultFormat, event, aFormulaEvaluator);
}
else {
    result = CellParser.parseMandatorySingleTime(resultCell, resultFormat, event, aFormulaEvaluator);
}
results[resultIdx - 1] = result;

Ideally, we'd assert that all the incomplete rows have the same number of solves entered, and that there aren't any gaps in that range.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants