Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges for PR/NR/CR/WR overflow the result table #130

Open
xsrvmy opened this issue Dec 14, 2022 · 4 comments
Open

Badges for PR/NR/CR/WR overflow the result table #130

xsrvmy opened this issue Dec 14, 2022 · 4 comments

Comments

@xsrvmy
Copy link

xsrvmy commented Dec 14, 2022

image

See here - the WR indicator clearly overflows the right side of the table. Noticed this due to the new PR indicators.

@jonatanklosko
Copy link
Member

This is intentional, this way don't need as much additional spacing, especially when there are no records :)

@xsrvmy
Copy link
Author

xsrvmy commented Dec 14, 2022

It's actually quite a common issue now with PRs being indicated.
I don't think a big padding beside the badge is necessary, just a few more pixels so WR doesn't go off the table.

@jonatanklosko
Copy link
Member

Is there a case where it gets outside the screen or something like that? I don't think overflowing the table is an issue in itself.

@xsrvmy
Copy link
Author

xsrvmy commented Dec 14, 2022

No, very close to on mobile though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants