Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent signing-event from running in forks #418

Closed
jku opened this issue Aug 27, 2024 · 1 comment
Closed

prevent signing-event from running in forks #418

jku opened this issue Aug 27, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented Aug 27, 2024

If a signer has enabled GitHub Actions in their fork, running tuf-on-ci-sign <event> leads to signing-event workflow running on their fork too: this is confusing so undesirable

  • The easy solution is likely if: github.repository_owner == 'upstream-org-name' in the workflow but we can't include that in the template workflow: it has to be done by each project
  • Alternatively we could make the action a no-op if the repository is a fork in general... that sounds like it could backfire
@jku
Copy link
Member Author

jku commented Jan 16, 2025

this is now commented out in the template workflows, I think best we can do

@jku jku closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant