Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider if asserts should/can have debug messages #213

Open
AdamKorcz opened this issue Oct 2, 2024 · 1 comment
Open

Consider if asserts should/can have debug messages #213

AdamKorcz opened this issue Oct 2, 2024 · 1 comment

Comments

@AdamKorcz
Copy link
Contributor

AdamKorcz commented Oct 2, 2024

We can consider if we should attach messages to asserts that explain the likely problem if it fails and why it should not fail. This can help clients save time, and client developers will need a lower degree of understanding of the internals of the conformance suite to use it; They won't need to know how we develop our tests to understand a failure.

@jku
Copy link
Member

jku commented Oct 2, 2024

Yeah this would make sense at least in cases where we currently do something like this

# comment explaining why we assert x
assert x

this could be just

assert x, "explanation here"

I assume pytest would show that in a reasonable way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants