Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for hashes/length in metafiles #131

Closed
jku opened this issue Aug 13, 2024 · 1 comment
Closed

Add tests for hashes/length in metafiles #131

jku opened this issue Aug 13, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented Aug 13, 2024

RepositorySimulator by default does not include hashes/length in METAFILE (so within timestamp and snapshot metadata).

We should have tests with them:

  • we should at a minimum have a simple test that does two ordinary refreshes against a repo that uses hashes/length ( and maybe against repos with only hashes or only length but this is less important): this verifies that client actually supports the feature
  • then could add tests where hashes/length data are set to wrong values to verify client actually uses the hashes/length
  • test_snapshot_rollback_with_local_snapshot_hash_mismatch() (RepositorySimulator._compute_hashes_and_length is broken #128) already has a very specific test about targets rollback -- it is currently broken though
  • possibly we could make all rollback tests parametrized so that they get run against repo without hashes/length as well as against a repo with hashes/length
@jku
Copy link
Member Author

jku commented Jan 30, 2025

  • test_basic_metadata_hash_support() exists now.
  • test_targets_rollback() and test_snapshot_rollback() are parametrized so test with and without hashes

@jku jku closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant