You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's inconsistent.
Someone consuming rtmidi with CMake config files must include public header with #include <rtmidi/RtMidi.h>, but with pkg-config it won't work and it will be #include <RtMidi.h>.
With add_subdirectory(), it is also #include <RtMidi.h>
Moreover, in all samples and tutorials, it's #include <RtMidi.h>
The text was updated successfully, but these errors were encountered:
In CMakeLists, include interface is defined under
include
(for CMake config file in install target):rtmidi/CMakeLists.txt
Line 197 in e8ae727
but headers are installed under
include/rtmidi
:rtmidi/CMakeLists.txt
Line 248 in e8ae727
In the meantime, .pc file says that include interface is under
include/rtmidi
:rtmidi/rtmidi.pc.in
Line 4 in e8ae727
It's inconsistent.
Someone consuming rtmidi with CMake config files must include public header with
#include <rtmidi/RtMidi.h>
, but with pkg-config it won't work and it will be#include <RtMidi.h>
.With
add_subdirectory()
, it is also#include <RtMidi.h>
Moreover, in all samples and tutorials, it's
#include <RtMidi.h>
The text was updated successfully, but these errors were encountered: