Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

44100 kHz format cannot be handled by topology files #59

Open
plbossart opened this issue Aug 23, 2018 · 4 comments
Open

44100 kHz format cannot be handled by topology files #59

plbossart opened this issue Aug 23, 2018 · 4 comments
Assignees
Labels
APL Apollolake Platform bug Something isn't working BYT Baytrail Platform CNL Cannonlake Platform P2 Critical bugs or normal features

Comments

@plbossart
Copy link
Member

plbossart commented Aug 23, 2018

Even when the codec works in master mode and can generate a 44.1kHz frame and associated bit clock, the format for the topology file prevents us from creating pipelines, DAIs and PCM devices working with 44.1 frames per ms.

Example of problematic macros, it's not clear how 48 might be replaced by 44.1...

PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
	1, 0, 2, s32le,
	48, 1000, 0, 0)

DAI_ADD(sof/pipe-dai-playback.m4,
	1, SSP, 5, SSP5-Codec,
	PIPELINE_SOURCE_1, 2, s24le,
	48, 1000, 0, 0)

This may have an impact of SOF as well since we assume the number of frames per ms is integer.

@plbossart plbossart added CNL Cannonlake Platform APL Apollolake Platform BYT Baytrail Platform P2 Critical bugs or normal features labels Aug 23, 2018
@mengdonglin mengdonglin added the bug Something isn't working label Aug 23, 2018
@mengdonglin mengdonglin assigned juimonen and unassigned lgirdwood Sep 13, 2018
@mengdonglin
Copy link
Collaborator

@juimonen Could you help to check this issue?

@juimonen
Copy link

yeah I will

@mengdonglin
Copy link
Collaborator

@juimonen Is this issue fixed or are you blocked?

@juimonen
Copy link

this is related to issue 60, which I'm in the middle of finishing. So the idea is to remove the frame count altogether from pipeline definition. I have a branch for this in my personal github account, but I don't won't to do PR yet as it needs much more testing. I have to do now now couple of more urgent things, but will continue with this in 1 or weeks.

@juimonen juimonen reopened this Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
APL Apollolake Platform bug Something isn't working BYT Baytrail Platform CNL Cannonlake Platform P2 Critical bugs or normal features
Projects
None yet
Development

No branches or pull requests

4 participants