-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] [IPC3] ALH Pin5 ipc tx error for 0x30010000. #9571
Comments
@bardliao , could you loop someone who can support this? Thank you. |
It seems only Pin 2, 3, 4 are supported by IPC3. @kv2019i @abonislawski can you take a look? |
@macchian @bardliao Do we have FW trace when this happens? Do we get the "stream_id %d out of range" error? |
@bardliao does this need a topology or FW fix ? |
@
@bardliao @kv2019i , I share the firmware traces and kernel logs with printed the alh_stream_id and dai_index. trace.logs: similar messages: Number of Blocks: total % used %d free %d dmesg: [ 4.397558] snd_sof:sof_widget_setup_unlocked: sof-audio-pci-intel-tgl 0000:00:1f.3: widget BUF6.0 setup complete |
@abonislawski , I share the fw traces. Could you add someone to check it? Thank you. |
Thanks @macchian for trace. This seems to be expected behaviour with current FW: src/platform/intel/cavs/lib/dai.c sets up the ALH dais and there's rule:
On cAVS2.5, DAI_NUM_ALH_BI_DIR_LINKS_GROUP is 4, so index 5 is not supported. @abonislawski Do you know why Icelake and Cannonlake seem to have DAI_NUM_ALH_BI_DIR_LINKS_GROUP of 6 ? |
@kv2019i @abonislawski do we need to update the value to 5 in cavs2.5 ipc3 FW to fix this ? |
@abonislawski @kv2019i ,do you want me to test any changes? Because this is a signed key machine, I am unable to build the signed key firmware on my end. Might need your test build if you have any suggestions. |
The PCM bidirectional FIFO count is 6 for Tigerlake hardware. Link: thesofproject#9571 Signed-off-by: Kai Vehmanen <[email protected]>
In that scenario "alh pin 5" = group index? We have 4 groups so it would be invalid. And btw we have incomplete handshake table in this file https://github.com/thesofproject/sof/blob/stable-v2.2/src/platform/tigerlake/include/platform/drivers/alh.h#L20 |
Looking at this from FW point of view, following values are valid to be set in IPCs:
|
Describe the bug
When creating a ALH Pin5 on SoundWire link 0, relevant pipeline, widget, buf and pcm ipc tx errors :
[ 5.060518] snd_sof:sof_widget_setup_unlocked: sof-audio-pci-intel-tgl 0000:00:1f.3: widget PIPELINE.5.ALH5.IN setup complete
[ 5.060520] snd_sof:ipc3_log_header: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx: 0x30010000
[ 5.060725] sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx error for 0x30010000 (msg/reply size: 96/0): -22
[ 5.060750] sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to setup widget ALH5.IN
[ 5.060765] snd_sof:ipc3_log_header: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx: 0x30110000
[ 5.061391] snd_sof:sof_widget_free_unlocked: sof-audio-pci-intel-tgl 0000:00:1f.3: widget PIPELINE.5.ALH5.IN freed
[ 5.061525] sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg component load failed -22
[ 5.061545] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -22
[ 5.061560] sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
[ 5.061597] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
To Reproduce
Steps to reproduce the behavior: (e.g. list commands or actions used to reproduce the bug)
When create a ALH Pin5 on SoundWire link 0
#ALH Pin5 (ID: 4)
DAI_CONFIG(ALH, 5, 4, `Capture-SmartMic',
ALH_CONFIG(ALH_CONFIG_DATA(ALH, 5, 48000, 2)))
Reproduction Rate
100%
Expected behavior
A clear and concise description of what you expected to happen.
ALH Pin5 is successfully to create the relevant pipeline, widget, buf and pcm.
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
The Soundwire device not available to support on board.
Environment
The text was updated successfully, but these errors were encountered: