Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SoundWire topologies: headset and mic capture are not processed consistently between IPC3 and IPC4 solutions #9307

Closed
plbossart opened this issue Jul 17, 2024 · 4 comments
Assignees
Labels
bug Something isn't working as expected
Milestone

Comments

@plbossart
Copy link
Member

Describe the bug

in IPC3 products, the headset capture does not have any EQIIR processing, while the mic capture does.

image

In IPC4 products, the headset capture does have an EQIIR processing while the mic capture does not.

image

This is inconsistent and leads to confusion on capabilities, as noted in thesofproject/linux#3766

To Reproduce
use existing topologies

Reproduction Rate

100%

Expected behavior

Consistent behavior for all new IPC4 products. We are not going to fix IPC3 at this point.

Impact

user experience, specifically pop-clicks on capture start

@singalsu please chime in with recommendations.

We can
a) add the EQIIR on mic capture and keep it active
b) remove EQIIR on all paths
c) all the EQIIR on mic capture but have the default as bypassed.

@plbossart plbossart added the bug Something isn't working as expected label Jul 17, 2024
@singalsu singalsu self-assigned this Jul 19, 2024
@singalsu
Copy link
Collaborator

Option a) probably. A low frequency cutoff highpass (e.g. 40 Hz) is a good bet for all acoustical mic applications. Option c) also works, we will be able to use UCM to set up the EQ when need.

Option b) is not feasible. The IIRs have been added after reports about strong DC pulses in capture begin or with headset button presses.

@plbossart
Copy link
Member Author

ok for a), makes sense to deal with button-press and other shenanigans, and IPC4 topology will be better than IPC3 ones.

@ranj063 is this something we can do with the pipeline extension stuff or are there still some dependencies to be worked out with the topology compiler?

@lgirdwood lgirdwood added this to the v2.11 milestone Aug 5, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 5, 2024

@singalsu v2.12 stuff?

@plbossart
Copy link
Member Author

I added the EQIIR for all IPC4 capture path in
#9331

So I think this can be closed?

@kv2019i kv2019i closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

4 participants