Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI result pages: make individual results linkable #477

Closed
kv2019i opened this issue Oct 29, 2020 · 8 comments
Closed

CI result pages: make individual results linkable #477

kv2019i opened this issue Oct 29, 2020 · 8 comments
Labels
type:enhancement New framework feature or request

Comments

@kv2019i
Copy link
Contributor

kv2019i commented Oct 29, 2020

In a CI result page like:
https://sof-ci.01.org/linuxpr/PR2524/build4796/devicetest/

Each PASS/FAILURE result now opens a pop-up. This is convenient when browsing the results, but when I need to communicate that one test failed on a specific platform, I don't have a link to copy that would take the reader directly to the failing test+platform. Instead I'll point to the https://sof-ci.01.org/linuxpr/PR2524/build4796/devicetest/ result page and have to type in that there's one failure on TGL RVP, or something to that effect.

Especially when merging, I'd like to be able to point to a specific failure. E.g. test run "link-to-failed-case" failed on this PR, but I've checked it and it's not related to this PR and I'm going to merge the PR still. Now I have to often end up just pointing to the whole results page and explaining that something failed, but I did check it, I think it's ok and will merge.

I know there are pros and cons, but I'm starting to lean towards preferring normal links versus popups.

@kv2019i kv2019i added the type:enhancement New framework feature or request label Oct 29, 2020
@kv2019i
Copy link
Contributor Author

kv2019i commented Oct 29, 2020

Additional problem: At least with Chrome, I can't copy'n'paste the DUT name from the table. So I end up manually copying the failing DUT type from the results to my mail/comment.

@aiChaoSONG
Copy link

Xiuli suggest to use anchor to do this.

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 10, 2020

@plbossart
Copy link
Member

What exactly does this 'Copy Link' do? I paste it in another tab and can't get any useful info. The only thing that gets downloaded is wav files that are not related to the test I was looking for.

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 10, 2020

The only thing that gets downloaded is wav files that are not related to the test I was looking for.

I never downloaded these and I don't link this automatic download either but I hope these files are related to the corresponding test! What happens after you cancel the download?

Here's another example without any automatic download https://sof-ci.01.org/softestpr/PR503/build373/devicetest/?model=ICL_RVP_HDA&testcase=verify-sof-firmware-load

@aiChaoSONG
Copy link

we have link for each test case on a model, can we close? @kv2019i

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 28, 2021

I (and many others) hve been using that feature a lot, it's extremely useful. So I confirm this is done, closing. @kv2019i please re-open if you "prefer popup to normal links" or if anything else was missed.

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 2, 2021

Each PASS/FAILURE result now opens a pop-up.

The technical term is "modal dialog" or (on the web) "modal overlay". Pop-ups are a different thing.

I know there are pros and cons, but I'm starting to lean towards preferring normal links versus popups.

The "Copy Link" button implemented here helped but it solved only one problem. I think a regular page would be much better for other reasons too. I created a "poll" to collect opinions, please vote up or down #816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New framework feature or request
Projects
None yet
Development

No branches or pull requests

4 participants