-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-case: Updated check-sof-logger.sh with SOF-specific codec #1248
Open
harajend
wants to merge
1
commit into
thesofproject:main
Choose a base branch
from
harajend:fix/sof-logger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch?
|
harajend
force-pushed
the
fix/sof-logger
branch
from
January 13, 2025 03:57
414f90c
to
ffda5b0
Compare
test this please |
marc-hb
reviewed
Jan 13, 2025
harajend
force-pushed
the
fix/sof-logger
branch
from
January 13, 2025 08:47
8a8a16e
to
05ffcc0
Compare
kv2019i
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers, PR seems good, but I'd encourage to look up old git commits to get a feel of the style on conventions used in this repo.
…SOF probes We have multiple sof* devices whenever SOF probes are enabled Signed-off-by: Hariprasad, Rajendra <[email protected]>
harajend
force-pushed
the
fix/sof-logger
branch
from
January 16, 2025 19:23
05ffcc0
to
402f4bd
Compare
marc-hb
approved these changes
Jan 16, 2025
ujfalusi
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SOF-specific codecs since the sof* regex also lists sofprobes
Should fix #1243