Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ownership transfer and acceptance for Ownable2Step contracts #3

Open
nkuba opened this issue Feb 22, 2024 · 0 comments
Open

Comments

@nkuba
Copy link
Member

nkuba commented Feb 22, 2024

Initially proposed by @r-czajkowski in thesis/acre#91 (comment).

We should consider supporting Ownable2Step way of transferring ownership on local deployment, to cover the execution of acceptOwnership function in our helpers.

Example of a deployment script that we could try to cover with helpers:

  await deployments.execute(
    "AcreBitcoinDepositor",
    { from: deployer, log: true, waitConfirmations: 1 },
    "transferOwnership",
    governance,
  )

  if (hre.network.name !== "mainnet") {
    await deployments.execute(
      "AcreBitcoinDepositor",
      { from: governance, log: true, waitConfirmations: 1 },
      "acceptOwnership",
    )
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant