Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When showing list of accounts available for connection to dapp, Ledger Live shows all available Bitcoin accounts, from multiple Ledgers #858

Open
michalinacienciala opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels

Comments

@michalinacienciala
Copy link
Contributor

@nkuba, we were discussing this as a potential issue. When trying to connect to dapp LL was showing all my accounts, from multiple Ledgers. When I chose the one that was not belonging to the Ledger I was connected with, I saw both steps of the Sign message LL modal and got the message displayed for signing on the Ledger device I was connected with. After signing in Ledger, an Invalid Sign In With Wallet signature | We encountered an error. Please try again. error was displayed in the dapp.

Screen.Recording.2024-11-14.at.09.08.46.mov

We were discussing that maybe the LL should not display on the CHOOSE ACCOUNT list the accounts belonging to the Ledger devices that are not connected to the user's computer.
I wonder if that would be achievable. It would require checking for Ledger connectivity at the moment when the CHOOSE ACCOUNT panel is displayed. If user would not have any Ledger connected yet, they would see no accounts available, only Add account button.

Alternative solutions that maybe could be implemented by LL:

  1. Before showing the message for signing, show some screen prompting the user to connect the right Ledger device that controls the chosen account
  2. On the CHOOSE ACCOUNT view group the accounts by the Ledger device they're connected with, to at least signalize to user that the accounts are managed by the different Ledger devices.

The above solutions may not be achievable if Ledger has no info about the belonging of a given account to a given device without user signing some message (which I suspect may be the case).

Let's contact LL to discuss potential solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants