Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog-zustand.tsx sandboy page will not work out of the box #13

Open
chrisLovesCode opened this issue Oct 6, 2022 · 2 comments
Open

Comments

@chrisLovesCode
Copy link

chrisLovesCode commented Oct 6, 2022

hey, i just like to let you guys know, that in https://github.com/theodorusclarence/expansion-pack/blob/main/dialog-zustand/src/pages/sandbox/dialog-zustand.tsx
the Layout component as outer wrapper is missing, so i was wondering why no dialog was showing, since i added the changes to my layout file :D
maybe should be added by default or it should be noted in the install insctructions :)

keep on the good work, love your stack so far! <3

@theodorusclarence
Copy link
Owner

Nice catch, @chrisLovesCode!

Do you want to contribute by adding Layout to the sandbox, or should I add it?

@chrisLovesCode
Copy link
Author

Nice catch, @chrisLovesCode!

Do you want to contribute by adding Layout to the sandbox, or should I add it?

feel free to add it, honestly, i need to have a read how to contrib to public git repos with a pr and such, did it the last time some years ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants