Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] Textdomain issue when updating theme in WordPress repository #2518

Open
mapsteps opened this issue Nov 12, 2023 · 1 comment
Open

Comments

@mapsteps
Copy link
Contributor

mapsteps commented Nov 12, 2023

Issue description:

Hey guys!

I've just noticed when updating Kirki to v5 in Page Builder Framework, an additional textdomain ('easy-digital-downloads') is being flagged when pushing to the WordPress repository.

It seems to be coming from the commit that merges the pro extensions into the free version - fac009b

For some reason, the file EDD_SL_Plugin_Updater.php was added which I think doesn't belong into the plugin at all.

image

We used to have the updater in the Kirki Pro Tabs (and others) in earlier commits when we were in charge of Kirki but removed those later on.

Looks to me that an older version of the Kirki Pro Tabs was merged into the free version and released with v5 (instead of the very latest master).

Can you please check?

Thank you! :)

Version used:

5.0

@mapsteps
Copy link
Contributor Author

Did a quick comparison between our latest master & the version of Kirki Pro Tabs included in Kirki. From what I can tell, you only need to delete the edd folder and the EDD_SL_Plugin_Updater.php file included in it and we should be fine :)

@mapsteps mapsteps changed the title [Important] Textdomain issue when updating theme in WordPress repository [CRITICAL] Textdomain issue when updating theme in WordPress repository Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant