You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just noticed when updating Kirki to v5 in Page Builder Framework, an additional textdomain ('easy-digital-downloads') is being flagged when pushing to the WordPress repository.
It seems to be coming from the commit that merges the pro extensions into the free version - fac009b
For some reason, the file EDD_SL_Plugin_Updater.php was added which I think doesn't belong into the plugin at all.
We used to have the updater in the Kirki Pro Tabs (and others) in earlier commits when we were in charge of Kirki but removed those later on.
Looks to me that an older version of the Kirki Pro Tabs was merged into the free version and released with v5 (instead of the very latest master).
Can you please check?
Thank you! :)
Version used:
5.0
The text was updated successfully, but these errors were encountered:
Did a quick comparison between our latest master & the version of Kirki Pro Tabs included in Kirki. From what I can tell, you only need to delete the edd folder and the EDD_SL_Plugin_Updater.php file included in it and we should be fine :)
mapsteps
changed the title
[Important] Textdomain issue when updating theme in WordPress repository
[CRITICAL] Textdomain issue when updating theme in WordPress repository
Dec 2, 2023
Issue description:
Hey guys!
I've just noticed when updating Kirki to v5 in Page Builder Framework, an additional textdomain ('easy-digital-downloads') is being flagged when pushing to the WordPress repository.
It seems to be coming from the commit that merges the pro extensions into the free version - fac009b
For some reason, the file
EDD_SL_Plugin_Updater.php
was added which I think doesn't belong into the plugin at all.We used to have the updater in the Kirki Pro Tabs (and others) in earlier commits when we were in charge of Kirki but removed those later on.
Looks to me that an older version of the Kirki Pro Tabs was merged into the free version and released with v5 (instead of the very latest master).
Can you please check?
Thank you! :)
Version used:
5.0
The text was updated successfully, but these errors were encountered: