Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need More Colors #21

Open
TheFuzz4 opened this issue Nov 30, 2019 · 5 comments
Open

Need More Colors #21

TheFuzz4 opened this issue Nov 30, 2019 · 5 comments

Comments

@TheFuzz4
Copy link

Hey there I love your videos and your shopping lists. This year we splurged and we set it up. So while 3 colors worked great for Thanksgiving, for Christmas my wife would like there to be 5 colors available, mainly so we can do Green, Red, White, Orange, Blue. Right now having just Green Red and White on there my wife says it looks like we're supporting a foreign country :). I'm looking at the code for this and I see where you declare the section starts and the red1, green1, blue1 so I see I would have to add sections for colors 4 and 5. However while I typically don't have an issue picking up something and running with it I just don't have enough know how at this time to go in here and just start taking your work and modifying it. Adding the additional colors to HA easy, adding them to this I'm a little lost.

@rjmcfadd
Copy link

Did you ever figure out how to add more colors? I would like this for Christmas as well. Thanks!

@zskullz
Copy link

zskullz commented Sep 26, 2020

I've just added the ability to select up to 5 different colors. For supported animations (ones that had 3 colors) it will dynamically add or remove the colors based off of the toggle switch in home assistant allowing the ability to make the animation have anywhere between 1 and 5 colors by simply toggling it in home assistant.

The code is compatible with current home assistant configuration so if your home assistant configuration is not updated, it will function with the 3 colors as it currently does.

@rjmcfadd
Copy link

I've just added the ability to select up to 5 different colors. For supported animations (ones that had 3 colors) it will dynamically add or remove the colors based off of the toggle switch in home assistant allowing the ability to make the animation have anywhere between 1 and 5 colors by simply toggling it in home assistant.

The code is compatible with current home assistant configuration so if your home assistant configuration is not updated, it will function with the 3 colors as it currently does.

Awesome, thank you! I'm getting an error while compiling this though, do you know what the issue is?
Holiday_LED_2.0_6_Zones:1426:21: error: 'byte zOneS1heat [400]' previously declared here static byte zOneS1heat[ZONEONE_SECTION1_END-ZONEONE_SECTION1_START]; ^ exit status 1 redeclaration of 'byte zOneS1heat [400]'

Thank you!

@zskullz
Copy link

zskullz commented Sep 26, 2020

Looks Like I missed some reference updates for zone 1. I checked the rest to be sure and it looks like that was the only one. I've just pushed up a fix that should take care of it.

@rjmcfadd
Copy link

Great, thank you, that worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants