From 3a8564efe8a07dede4b66da8863474a0fc76b4f7 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Tue, 12 Mar 2024 15:29:07 -0400 Subject: [PATCH 1/4] Upload the DLLs to the symbol server --- .github/workflows/bcny-ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index d9ae22d7d..57e63f246 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -108,3 +108,11 @@ jobs: personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin searchPattern: '**/*.pdb' + + - name: Upload DLLs to Azure + uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 + with: + accountName: thebrowsercompany + personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} + symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin + searchPattern: '**/*.dll' From 6bc8bc8abbdbb932d4bebfc38a76639c2a45db45 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Tue, 12 Mar 2024 16:34:56 -0400 Subject: [PATCH 2/4] Use glob --- .github/workflows/bcny-ci.yml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 57e63f246..a22171513 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -107,12 +107,4 @@ jobs: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin - searchPattern: '**/*.pdb' - - - name: Upload DLLs to Azure - uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 - with: - accountName: thebrowsercompany - personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin - searchPattern: '**/*.dll' + searchPattern: '**/*.@(dll|exe|pdb)' From 5bfc89455a77c086e9a21d2da471eadd43edaf40 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Tue, 12 Mar 2024 16:41:12 -0400 Subject: [PATCH 3/4] Use other pattern --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index a22171513..16a9248c8 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -107,4 +107,4 @@ jobs: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin - searchPattern: '**/*.@(dll|exe|pdb)' + searchPattern: '**/*.{dll,exe,pdb}' From b2d2b6f386db7a370fba5fb013a8a757df39145b Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Tue, 12 Mar 2024 16:52:58 -0400 Subject: [PATCH 4/4] Revert to the 2 steps approach --- .github/workflows/bcny-ci.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 16a9248c8..57e63f246 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -107,4 +107,12 @@ jobs: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin - searchPattern: '**/*.{dll,exe,pdb}' + searchPattern: '**/*.pdb' + + - name: Upload DLLs to Azure + uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 + with: + accountName: thebrowsercompany + personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} + symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin + searchPattern: '**/*.dll'