From acc9f386e64eead30af60966fc7b11cd2d2d0687 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 12:36:14 -0500 Subject: [PATCH 1/9] Upload PDBs to the symbol server --- .github/workflows/bcny-ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 9ee86c549..0371dac1d 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -100,3 +100,12 @@ jobs: $pkgs = Get-ChildItem -Path io.sentry.sentry-native.crashpad.windows.*.nupkg nuget push $pkgs[0].Name -Source ${env:NUGET_SOURCE_URL} -SkipDuplicate shell: pwsh + + - name: Upload PDBs to Azure + if: always() + uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 + with: + accountName: thebrowsercompany + personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} + symbolsFolder: ${{ env.DESTDIR }}\bin + searchPattern: '**/*.pdb' From 3cc28a00ac999a151026e69fe0ef7113fe49287e Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 13:21:01 -0500 Subject: [PATCH 2/9] Change condition --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 0371dac1d..9e47f3e04 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -102,7 +102,7 @@ jobs: shell: pwsh - name: Upload PDBs to Azure - if: always() + if: success() uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 with: accountName: thebrowsercompany From c089a7b7dd6b4feb651b28e9ed2c32afd34bc177 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 13:25:29 -0500 Subject: [PATCH 3/9] Change syntax --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 9e47f3e04..3f0963e6c 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -107,5 +107,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: ${{ env.DESTDIR }}\bin + symbolsFolder: `$DESTDIR`$\bin searchPattern: '**/*.pdb' From 630be9bc0650b983f552bdd2febc2faef992cd53 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 13:26:04 -0500 Subject: [PATCH 4/9] Drop condition --- .github/workflows/bcny-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 3f0963e6c..64af89c91 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -102,7 +102,6 @@ jobs: shell: pwsh - name: Upload PDBs to Azure - if: success() uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68 with: accountName: thebrowsercompany From f6ffe701408255cf01060a40b0b67d348bf1a7b0 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 15:04:38 -0500 Subject: [PATCH 5/9] Fix path --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 64af89c91..d392f80b6 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -106,5 +106,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: `$DESTDIR`$\bin + symbolsFolder: entry-native-development/usr/bin searchPattern: '**/*.pdb' From 3fbafbfb0421ba90eaf6b2e451d27e57e92f495d Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 15:26:20 -0500 Subject: [PATCH 6/9] Throwing more spaghettis at the wall --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index d392f80b6..49480d82a 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -106,5 +106,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: entry-native-development/usr/bin + symbolsFolder: ${{ github.workspace }}/entry-native-development/usr/bin searchPattern: '**/*.pdb' From 67646680890a40036b7769e1f84bf70765f21689 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 15:31:45 -0500 Subject: [PATCH 7/9] With meatballs --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 49480d82a..982297f2c 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -106,5 +106,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: ${{ github.workspace }}/entry-native-development/usr/bin + symbolsFolder: ${{ github.workspace }}\entry-native-development\usr\bin searchPattern: '**/*.pdb' From 3156b2308e152ecea78e13c941ba0eb63a674e8d Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 15:38:15 -0500 Subject: [PATCH 8/9] And some parmesan --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 982297f2c..623e9ba67 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -106,5 +106,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: ${{ github.workspace }}\entry-native-development\usr\bin + symbolsFolder: ${{ github.workspace }}\..\entry-native-development\usr\bin searchPattern: '**/*.pdb' From 3084c1c0af506915f0b42eeaf5d705a57e1503f1 Mon Sep 17 00:00:00 2001 From: Sebastien Marchand Date: Thu, 15 Feb 2024 15:47:15 -0500 Subject: [PATCH 9/9] Pair with a glass of Chardonnay --- .github/workflows/bcny-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bcny-ci.yml b/.github/workflows/bcny-ci.yml index 623e9ba67..d9ae22d7d 100644 --- a/.github/workflows/bcny-ci.yml +++ b/.github/workflows/bcny-ci.yml @@ -106,5 +106,5 @@ jobs: with: accountName: thebrowsercompany personalAccessToken: ${{ secrets.SYMBOL_SERVER_PAT }} - symbolsFolder: ${{ github.workspace }}\..\entry-native-development\usr\bin + symbolsFolder: ${{ github.workspace }}\sentry-native-development\usr\bin searchPattern: '**/*.pdb'