Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Improve on get_width_height script #12

Open
thatlittleboy opened this issue Jun 12, 2022 · 0 comments
Open

[ENH] Improve on get_width_height script #12

thatlittleboy opened this issue Jun 12, 2022 · 0 comments

Comments

@thatlittleboy
Copy link
Owner

thatlittleboy commented Jun 12, 2022 •
edited
Loading

From #11 , I added in a script to scrape the image height and width from the source URL, and write it back into the db.yaml file.

There are a few possible improvements:

  1. Use async / await instead of sequentially calling. [DONE]
  2. Incorporate the use of this script as a test (unconfirmed, since this might slow down tests ALOT) to make sure width/height is always provided, and is up-to-date with the image on the source URL.
  3. Currently script is writing to new_db.yaml; it should overwrite db.yaml?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatlittleboy