Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzzy query test failed on latest main #326

Closed
yeya24 opened this issue Nov 19, 2023 · 1 comment · Fixed by #328
Closed

Fuzzy query test failed on latest main #326

yeya24 opened this issue Nov 19, 2023 · 1 comment · Fixed by #328

Comments

@yeya24
Copy link
Contributor

yeya24 commented Nov 19, 2023

Fuzzy query test failed on latest main after merging #324.

GH action log: https://github.com/thanos-io/promql-engine/actions/runs/6919173003/job/18822211713

    enginefuzz_test.go:128: load 30s
        			http_requests_total{pod="nginx-1", route="/"} 1.00+1.00x4
        			http_requests_total{pod="nginx-2", route="/"}  1+2.00x4
    enginefuzz_test.go:129: group by (pod, route) (atanh(-{__name__="http_requests_total"} offset -3m4s))
    enginefuzz_test.go:131: case 43 error mismatch.
        new result: 
        old result: {pod="nginx-1", route="/"} => 1 @[0]
        {pod="nginx-2", route="/"} => 1 @[0]
    enginefuzz_test.go:136: failed 1 test cases
--- FAIL: FuzzDistributedEnginePromQLSmithInstantQuery (1.89s)
    --- FAIL: FuzzDistributedEnginePromQLSmithInstantQuery/seed#0 (1.89s)
FAIL
FAIL	github.com/thanos-io/promql-engine/engine	416.641s

Haven't got the chance to take a closer look. If this is a false positive then we can close.
@fpetkovski
Copy link
Collaborator

fpetkovski commented Nov 19, 2023 •
edited
Loading

Hm this could be related to my change, I will take a look tomorrow morning.

fpetkovski added a commit to fpetkovski/promql-engine that referenced this issue Nov 20, 2023
@fpetkovski
Fix group aggregate with NaN values
1b762e4 
The group aggregate should produce an output value even when inputs are NaN.

Fixes thanos-io#326.
@fpetkovski fpetkovski mentioned this issue Nov 20, 2023
Merged
fpetkovski added a commit to fpetkovski/promql-engine that referenced this issue Nov 20, 2023
@fpetkovski
Fix group aggregate with NaN values
1c560c7 
The group aggregate should produce an output value even when inputs are NaN.

Fixes thanos-io#326.

Signed-off-by: Filip Petkovski <[email protected]>
yeya24 pushed a commit that referenced this issue Nov 20, 2023
@fpetkovski
Fix group aggregate with NaN values (#328)
da65a9d 
The group aggregate should produce an output value even when inputs are NaN.

Fixes #326.

Signed-off-by: Filip Petkovski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix group aggregate with NaN values fpetkovski/promql-engine
2 participants
@fpetkovski @yeya24