Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency for CLLocationManager #69

Closed
RemiBardon opened this issue May 20, 2023 · 1 comment · May be fixed by #70
Closed

Add dependency for CLLocationManager #69

RemiBardon opened this issue May 20, 2023 · 1 comment · May be fixed by #70

Comments

@RemiBardon
Copy link

There is no dependency for CLLocationManager yet, I am working on adding support for it.
RemiBardon added a commit to RemiBardon/swift-dependencies-additions that referenced this issue May 20, 2023
@RemiBardon
Add LocationManagerDependency (tgrapperon#69)
cae4c8d
@RemiBardon RemiBardon mentioned this issue May 20, 2023
Open
9 tasks
@tgrapperon
Copy link
Owner

Hey @RemiBardon! Thanks for opening the discussion. I refrained to propose such a dependency because I think that Brandon and Stephen have planned to rework composable-core-location, and I feel that this will uncouple it from TCA and make it a standalone dependency. That's why I'm not leaning toward merging the PR right now, but I'll give it a proper look very soon anyway!
I'm also converting this issue as a discussion, as this is not a direct problem with what the library exposes right now.

Repository owner locked and limited conversation to collaborators May 20, 2023
@tgrapperon tgrapperon converted this issue into discussion #72 May 20, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LocationManagerDependency (#69) RemiBardon/swift-dependencies-additions
2 participants
@tgrapperon @RemiBardon