forked from symplify/phpstan-rules
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathRequireConstantInMethodCallPositionRule.php
151 lines (132 loc) · 3.89 KB
/
RequireConstantInMethodCallPositionRule.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
<?php
declare(strict_types=1);
namespace Symplify\PHPStanRules\Rules\Enum;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PHPStan\Analyser\Scope;
use Symplify\PHPStanRules\Matcher\PositionMatcher;
use Symplify\PHPStanRules\Rules\AbstractSymplifyRule;
use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Symplify\PHPStanRules\Tests\Rules\Enum\RequireConstantInMethodCallPositionRule\RequireConstantInMethodCallPositionRuleTest
*/
final class RequireConstantInMethodCallPositionRule extends AbstractSymplifyRule implements ConfigurableRuleInterface
{
/**
* @var string
*/
public const ERROR_MESSAGE = 'Parameter argument on position %d must use constant';
/**
* @param array<class-string, mixed[]> $requiredConstantInMethodCall
*/
public function __construct(
private PositionMatcher $positionMatcher,
private array $requiredConstantInMethodCall
) {
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
* @return string[]
*/
public function process(Node $node, Scope $scope): array
{
if (! $node->name instanceof Identifier) {
return [];
}
return $this->getErrorMessages($node, $scope, $this->requiredConstantInMethodCall);
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(self::ERROR_MESSAGE, [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function someMethod(SomeType $someType)
{
$someType->someMethod('hey');
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
private const HEY = 'hey'
public function someMethod(SomeType $someType)
{
$someType->someMethod(self::HEY);
}
}
CODE_SAMPLE
,
[
'requiredLocalConstantInMethodCall' => [
'SomeType' => [
'someMethod' => [0],
],
],
]
),
]);
}
/**
* @param array<class-string, mixed[]> $config
* @return string[]
*/
private function getErrorMessages(MethodCall $methodCall, Scope $scope, array $config): array
{
/** @var Identifier $name */
$name = $methodCall->name;
$methodName = (string) $name;
$errorMessages = [];
foreach ($config as $type => $positionsByMethods) {
$positions = $this->positionMatcher->matchPositions(
$methodCall,
$scope,
$type,
$positionsByMethods,
$methodName
);
if ($positions === null) {
continue;
}
foreach ($methodCall->args as $key => $arg) {
if (! $arg instanceof Arg) {
continue;
}
if ($this->shouldSkipArg($key, $positions, $arg)) {
continue;
}
$errorMessages[] = sprintf(self::ERROR_MESSAGE, $key);
}
}
return $errorMessages;
}
/**
* @param int[] $positions
*/
private function shouldSkipArg(int $key, array $positions, Arg $arg): bool
{
if (! in_array($key, $positions, true)) {
return true;
}
if ($arg->value instanceof Variable) {
return true;
}
return $arg->value instanceof ClassConstFetch;
}
}