Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncaught payout failures #621

Open
nicolasochem opened this issue Sep 25, 2022 · 0 comments
Open

uncaught payout failures #621

nicolasochem opened this issue Sep 25, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@nicolasochem
Copy link
Contributor

Follow up from #619

In kathmandu, some rpc fields changed names resulting in a python exception when calculating payouts.

The exception was inproperly caught, resulting the failed payouts to NOT be listed in the failed folder. Instead, they were listed in the done folder with a status of undefined.

We are missing a try/catch somewhere, so when such errors happen, we mark payout as failed, and an updated TRD can then reprocess the payouts without needing to manipulate files by hand.

To replicate:

  • revert e1c5e4e
  • run a payout where some delegators are KT1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants