Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument call to sealContract in end to end tests #313

Open
dorranh opened this issue Dec 22, 2021 · 1 comment
Open

Instrument call to sealContract in end to end tests #313

dorranh opened this issue Dec 22, 2021 · 1 comment

Comments

@dorranh
Copy link
Contributor

dorranh commented Dec 22, 2021

The call to sealContract is not currently instrumented in our tests, which means that we won't see reports of its gas costs. We should add support for this in our end to end tests.
@gkaracha
Copy link
Contributor

gkaracha commented Jan 3, 2022

Ah, yes, indeed! Expect this to be the most expensive of all though, since internally it calls touch and pokes all helper contracts 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkaracha @dorranh