Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plural of secondaryIdentifiers #2

Open
stevelooo opened this issue May 8, 2024 · 1 comment
Open

plural of secondaryIdentifiers #2

stevelooo opened this issue May 8, 2024 · 1 comment

Comments

@stevelooo
Copy link

stevelooo commented May 8, 2024 •
edited
Loading

"secondaryIdentifiers" is just one single object, not an array of identifiers. Therefore, better to change the name to singular which is "secondaryIdentifier"

or should this field be an array of object? but missing the [] after "object"?
ChrisSquats added a commit that referenced this issue May 8, 2024
@ChrisSquats
Fix #1 and #2
9c5a865
swithinfoote added a commit that referenced this issue May 19, 2024
@swithinfoote
Merge pull request #3 from tewhatuora/1-add-missing-fields
af8b4b7 
Fix #1 and #2
@stevelooo
Copy link
Author

only the json file is changed. missed the yaml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevelooo