[Airsonic] Others - Each single topic (10)

[tesshucom]

Problem description

This issue was ported from the Airsonic archive. The top node for these issues is #1725.

It does not necessarily aim to solve all problems. However, some points of view will be fed back as Jpsonic is improved in the future.

It also includes issues that have already been resolved by Jpsonic at this stage. These will be progressively organized by topic.

System information

• Jpsonic version: since v111.5.4

New task is issued

• Fix CORS airsonic/airsonic#1790
  • -> Add CORS test cases #1833
• [WIP] Add a preference to disable all external services airsonic/airsonic#993
  • -> Add a preference to disable all external services #1830

Closed

Tracking of the following agenda is closed.

• Feature Request: composer tag support airsonic/airsonic#609
• Jpspnic supports composer. Below is additional information.
  • Jpsonic and Airsonic have different file formats that can be parsed. In Airsonic, an error occurs due to a defect when reading "doubt" in the table.

extension	Scan target (Default)	parsable
		Airsonic	Jpsonic
mp3	Y	Y	Y
ogg	Y	Y	Y
oga	Y		Y
m4a	Y	Y	Y
m4b	Y	Y	Y
flac	Y	Y	Y
wav	Y	Y	Y
wma	Y	Y	Y
aif	Y		Y
aiff	Y		Y
ape	Y
shn	Y
mka	Y
opus	Y
aac	Y	Y(doubt)
mpc	Y	Y(doubt)
mp+		Y(doubt)
ape		Y(doubt)
aifc			Y
dsf			Y
dff			Y

"parsable" file will be tag parsed. Below is the mapping. In short, sort and composer are added when compared with Airsonic. The parser has also undergone a major version upgrade, incorporating numerous bug fixes. Further logging improvements have been made. Convenience has been improved, such as displaying messages in one-line logs when tags cannot be read.

extension	mp3, aif, aiff, aifc, dsf, (wav)			m4a, m4b	flac, ogg, oga	wma
Attribute	ID3v22	ID3v23	ID3v24	Mp4	VorbisComment	Wma
Title	TITLE	TIT2	TIT2	©nam	TITLE	Title
Title Sort Order	TITLE_SORT	TSOT	TSOT	sonm	TITLESORT	WM/TitleSortOrder
Artist	ARTIST	TPE1	TPE1	©ART	ARTIST	Author
Artist Sort Order	ARTIST_SORT	TSOP	TSOP	soar	ARTISTSORT	WM/ArtistSortOrder
Album	ALBUM	TALB	TALB	©alb	ALBUM	WM/AlbumTitle
Album Sort Order	ALBUM_SORT	TSOA	TSOA	soal	ALBUMSORT	WM/AlbumSortOrder
Album Artist	ALBUM_ARTIST	TPE2	TPE2	aART	ALBUMARTIST	WM/AlbumArtist
Album Artist Sort Order	ALBUM_ARTIST_SORT	TSO2	TSO2	soaa	ALBUMARTISTSORT	WM/AlbumArtistSortOrder
Genre	GENRE	TCON	TCON	©gen	GENRE	WM/Genre
Date	YEAR	TYER+TDAT	TDRC	©day	DATE	WM/Year
Composer	COMPOSER	TCOM	TCOM	©wrt	COMPOSER	WM/Composer
Composer Sort Order	COMPOSER_SORT	TSOC	TSOC	soco	COMPOSERSORT	WM/ComposerSortOrder
Track Number	TRACK	TRCK	TRCK	trkn	TRACKNUMBER	WM/TrackNumber
Disc Number	DISC_NO	TPOS	TPOS	disk	DISCNUMBER	WM/PartOfSet
MusicBrainz Track Id	MUSICBRAINZ_RECORDING_ID	UFID:http://musicbrainz.org	UFID:http://musicbrainz.org	----:com.apple.iTunes:MusicBrainz Track Id	MUSICBRAINZ_TRACKID	MusicBrainz/Track Id
MusicBrainz Original Release Id	MUSICBRAINZ_ORIGINAL_RELEASE_ID	TXXX:MusicBrainz Original Album Id	TXXX:MusicBrainz Original Album Id	----:com.apple.iTunes:MusicBrainz Album Id	MUSICBRAINZ_ORIGINALALBUMID	MusicBrainz/Album Id

• Internet Radio 10.4.0 - shoutcast playlist will not play airsonic/airsonic#1169

  • SHOUTcast removed in Jpsonic.
    • SHOUTcast doesn't have a lot of traffic even from a global perspective, and the areas where it's used are quite uneven.
    • That method we may be subject to XSS warnings. At least it doesn't seem like a feature that should be enabled by default without the user knowing...?

• Remove Direct Web Remoting (DWR) airsonic/airsonic#1501

  • I do not deny the proposed removal of DWR. I think there should be an argument to change it to something at some point.　However, it will be conditional that the alternative is introduced without any disadvantages, that the obviously extra work does not put pressure on the development of the main flow, and that it does not introduce any bugs. Validation, agreed scheduling, precision implementation and new testing are therefore required.
  • There are opinions that I can almost agree with.

    • This has been the path (I feel) we never wanted to follow and try not to waist time on.

    • Now I'm wondering whether the effort is toward adding few endpoints here and there, or to design a new modern REST API that could be used for a future Single page application ?

  • Web technology evolves very quickly, but it is often the case that later technologies are not necessarily upwardly compatible technologies. Just like Darwin's genealogical tree, there must be a mainstream and minor offshoots or discontinued technologies. This discussion is exactly that.
  • Even though it was said "This technology will speed things up!!", it had been slower due to the pressure on resources, actually. It happens all the time. It also requires measurement. About speed and resources.

• Sonos integration failing airsonic/airsonic#1757

  • Sonos removed in Jpsonic.
  • Not that Sonos thinks it's unnecessary, though. The functionality and quality of the existing implementation did not justify the maintenance costs. It's just that the overhead of maintaining hello world was a little high.
    • Therefore, we are ready to accept pull requests for full-featured implementations based on our latest API, and well-tested. Come on!
    • If the functionality is on par with the UPnP functionality implemented in Jpsonic, I think it's good enough for users.

• substreamer app airsonic/airsonic#1860

  • It's invisible to the user... but the substreamer makes connections in a somewhat peculiar way.
    • I don't think it's malicious, but the substreamer uses connection methods that are not accepted by default on some application servers for security reasons. (It's not a mistake, but it seems that such a specification should not be decided by the client application. Personal opinion)
    • if you connect to Jpsonic(Jetty-embedded) with substreamer, certain operations will generate a lot of warnings. I have no intention of suppressing this. (Because it will be troublesome when a really malicious connection is made)
    • Tomcat, on the other hand, is tolerant of this. So if you want to use substreamer, deploy it to Tomcat.

• Support for OpenLiberty instead of Tomcat airsonic/airsonic#1861

  • Airsonic chose Tomcat because it is common for engineers. Jpsonic has adopted Jetty because Jetty is more suitable for their requirements. Jetty is the same as Subsonic, and Jpsonic uses mostly the latest version.
  • I saw the OpenLiberty proposal with interest, but you might want to try it yourself as commented. If you get good results, we welcome pull requests.
    • However, application servers are not chosen solely for their speed. Robustness, frequency of version upgrades, and speed of security fixes are also important points of view. Including those, I think Jetty is probably the best.
    • OpenLiberty may be a candidate if there is a requirement for differential updates. However, it is outside the scope of this project.
  • In fact, Tomcat hasn't been discontinued at Jpsonic. Jetty and Tomcat are selectable when compiling. Airsonic was also developed this way at the beginning, but Jetty was removed due to its maintainance complexity.
    • mvn clean package -Dmaven.test.skip=true -Dpmd.skip=true -Pjetty-embed -Prelease17
    • mvn clean package -Dmaven.test.skip=true -Dpmd.skip=true -Ptomcat-embed -Prelease17
  • Here are our plans for the future : Bump Tomcat && Jetty && Spring Boot #839

• Unable to access any external drives on ubuntu 20.04 airsonic/airsonic#1736

• Folder not found :( airsonic/airsonic#1862

  • Find out how to "mount" an external hard disk. Opinions exchanged mainly on reddit and stackoverflow are often difficult to answer on Github. Please don't blame the developers for that... I think this information about Subsonic and Airsonic is relatively easy to find. When using reddit or stackoverflow, I think it's easier to get an answer if you can explain your environment.
  • If you connect to NAS with Docker, there may be restrictions on NFS and SMB versions due to Docker specifications. These are also documented in the Docker documentation.