Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lasso feedback/questions #33

Closed
jgravois opened this issue Apr 16, 2020 · 1 comment
Closed

lasso feedback/questions #33

jgravois opened this issue Apr 16, 2020 · 1 comment

Comments

@jgravois
Copy link
Member

intersects(polygon, point) returns true if point is inside polygon, but throws "Type Polygon to Point intersection is not supported by intersects" if it is not inside. Obviously it is an issue of not respecting false return value at the same line as above, but it is correct false in this case. This issue exists also in the original Terraformer, I just ignored it and forced to use contains with points (https://github.com/zakjan/leaflet-lasso/blob/master/src/calc.ts#L47-L49). Is there possibly another way of detecting that intersection is not supported? What specific combination of types is actually not supported?

createCircle still returns incorrrect radius and it is missing export. But I can stay with the other dependency.

@jgravois
Copy link
Member Author

tracking in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant