-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support installing plugins from GitHub Enterprise #1643
Comments
This is an issue that we've just encountered. We've written a custom plugin and created a release but are unable to use that plugin because the source is github.<company_name>.com as we are using a github enterprise. Are there plans to implement this in the near future? |
There are no plans, if you need this in the near future please take the time to follow the guidance above and make an attempt at a PR. |
Re: #1734
Works for your setup, sure, but not an appropriate generic solution. There's no requirement on hostnames and users could pick If anything, the way to validate a GitHub server is to make a request to If you can get this 80% of the way there, I can review/finish it. I don't have a GHES instance to test against nor can we test this in CI so we definitely need someone to step up to see this one through. |
TFLint plugins are installed from GitHub, using its releases API. While there are no plans to support other plugin sources, we should support alternate GitHub installations (GitHub Enterprise).
See
BaseURL
: https://pkg.go.dev/github.com/google/go-github/github#ClientCurrently the code creates a new GitHub client for each installation rather than sharing across the whole command run. So it's theoretically possible to mix plugins from different hosts without major refactoring. Currently, the internal plugin config has
SourceOwner
andSourceRepo
. It would also needSourceHost
. That could then be used to construct the base URL for the GitHub client for that plugin.Debug logs that hardcode
https://api.github.com
should be amended to useBaseURL
.Originally requested in #1202 (comment)
The text was updated successfully, but these errors were encountered: