Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the upsample test that blocked #16975 due to invalid sharding #17035

Open
jvegaTT opened this issue Jan 23, 2025 · 1 comment
Open

Re-enable the upsample test that blocked #16975 due to invalid sharding #17035

jvegaTT opened this issue Jan 23, 2025 · 1 comment
Assignees
@shwetankTT
Labels
bug Something isn't working P1

Comments

@jvegaTT
Copy link
Contributor

jvegaTT commented Jan 23, 2025

To unblock the P0 issue

#16977

The following test was removed

pytest tests/ttnn/unit_tests/operations/test_upsample.py::test_upsample_multi_core[shard_orientation=ShardOrientation.ROW_MAJOR-shard_strategy=ShardStrategy.BLOCK-scale_w=2-scale_h=2-device_params={'l1_small_size': 24576}-input_shape=[2, 1280, 4, 4]]

This issue needs to actually be resolved and the commented out test restored
@jvegaTT jvegaTT added the bug Something isn't working label Jan 23, 2025
@jvegaTT jvegaTT changed the title Re-enable the sample test that blocked #16975 due to invalid sharding Re-enable the upsample test that blocked #16975 due to invalid sharding Jan 23, 2025
@jvegaTT jvegaTT mentioned this issue Jan 23, 2025
Merged
6 tasks
jvegaTT added a commit that referenced this issue Jan 23, 2025
@jvegaTT
#16948: Temporarily removing the blocking tests to unblock (#17034)
72d5f79 
### Ticket
#16975 

### Problem description
Removing some the failing tests to unblock the above P0

### What's changed
The tests were removed but the following issues were opened to track
their re-introduction:
#17029 
#17030 
#17031 
#17035

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
This was referenced Jan 23, 2025
Open
Closed
@mywoodstock mywoodstock removed their assignment Jan 23, 2025
@mywoodstock mywoodstock added the P1 label Jan 23, 2025
@shwetankTT
Copy link
Contributor

The issue has been resolved here. #17028
Anything needed from my end.

shwetankTT added a commit that referenced this issue Jan 24, 2025
@shwetankTT
#17035: issue resolved and merged already #17028. Unblocking the test…
8698a0f 
… cases.
patrickroberts pushed a commit that referenced this issue Jan 25, 2025
@jvegaTT @patrickroberts
#16948: Temporarily removing the blocking tests to unblock (#17034)
aff0287 
### Ticket
#16975 

### Problem description
Removing some the failing tests to unblock the above P0

### What's changed
The tests were removed but the following issues were opened to track
their re-introduction:
#17029 
#17030 
#17031 
#17035

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shwetankTT shwetankTT

Labels
bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mywoodstock @shwetankTT @jvegaTT