Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide flag to tell the update handler that the handling is from a re-apply #564

Open
longquanzheng opened this issue Nov 26, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@longquanzheng
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

In non-reset case, we will have a short or no activity retry, so that the error would return to the caller/client early.
However, on a retry with re-apply, we need to ensure the activity will not fail, because the update has been considered completed (just like signal has been accepted) from the client.

Right now this is not possible.

Kinda related to temporalio/temporal#5873
If the workflowContext can tell that the workflowTask is from a reset, that's probably enough?

Describe the solution you'd like
A clear and concise description of what you want to happen.
SDK should know this info (the update is from Admitted event), just provide a flag to us.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
NA

Additional context
Add any other context or screenshots about the feature request here.

@longquanzheng longquanzheng added the enhancement New feature or request label Nov 26, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns transferred this issue from temporalio/sdk-go Nov 26, 2024
@Quinn-With-Two-Ns
Copy link
Contributor

Transferring to features since this is not specific to the Go SDK

@Quinn-With-Two-Ns
Copy link
Contributor

To clarify, do you want to know if the update request came being reapplied from a reset? Since temporalio/temporal#5873 refers to a workflow task, but updates can span multiple workflow tasks.

@longquanzheng
Copy link
Author

longquanzheng commented Nov 27, 2024

if the update request came being reapplied from a reset?

Yes, that's right.

Since temporalio/temporal#5873 refers to a workflow task, but updates can span multiple workflow tasks.

That's true. So that workflow context is less ideal. But should be enough if I write the code carefully (passing the flag to later handling logic) 😂

@dandavison
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants