New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading bootstrap3.min.js to Bootstrap v3.4.1 #30

Open

1 task

westurner opened this issue Aug 26, 2019 · 0 comments

Contributor

westurner commented Aug 26, 2019 •

edited

Loading

bootstrap3.min.js has bootstrap v3.3.4

From https://getbootstrap.com/docs/3.4/getting-started/#download :

For v3, v3.4.1 is latest
For v4 (which does have different CSS class names), v4.3.1 is latest

None of these seem that pressing, given that user input is controlled and we're 'only generating static pages', but who knows:
https://www.cvedetails.com/vulnerability-list/vendor_id-19522/product_id-51406/Getbootstrap-Bootstrap.html

Does upgrading to v3.4.1 break anything in sphinxjp.themes.basicstrap?
(see also Upgrading jquery.min.js #29 "Upgrading jquery.min.js")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment