Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Include and Exclude by Regex Pattern #24

Closed
jacobeatsspam opened this issue Nov 8, 2024 · 6 comments
Closed

[feature request] Include and Exclude by Regex Pattern #24

jacobeatsspam opened this issue Nov 8, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jacobeatsspam
Copy link

I have a bunch of tables that share a common prefix and I would like to exclude them. This could be done with a simple glob/wildcard, or regex.

@tedivm tedivm added enhancement New feature or request good first issue Good for newcomers labels Nov 8, 2024
@tedivm
Copy link
Owner

tedivm commented Nov 8, 2024

This is a good one! I will happily take a pull request for it if you want it soon, otherwise I'll add this to my project queue.

@tedivm tedivm changed the title [feature request] Exclude by wildcard [feature request] Include and Exclude by Regex Pattern Nov 8, 2024
@rabelmervin
Copy link
Contributor

Hi @tedivm @jacobeatsspam I would like to contribute to this issue ! Any guidance would be appreciated 👍

@tedivm
Copy link
Owner

tedivm commented Nov 10, 2024

The logic for the table selection is in the resolve_includes_tables function. Right now the arguments for includes and excluded tables uses pretty basic string matching, and this would have to be replaced with something that iterates over the tables to do a regular expression instead.

You'll likely want to start by writing some tests with the desired functionality.

@rabelmervin
Copy link
Contributor

Thanks @tedivm excited to work on this !

@rabelmervin
Copy link
Contributor

hi @tedivm @jacobeatsspam pr made, Could you please tell me if there is any changes or mistakes ?

@tedivm
Copy link
Owner

tedivm commented Nov 21, 2024

resolved by #26

@tedivm tedivm closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants